Options to save multiple meshes from segmentations#46
Options to save multiple meshes from segmentations#46JuhaHuiskonen wants to merge 6 commits intoCellArchLab:masterfrom
Conversation
…-return-all-meshes Support exporting multiple segmentation meshes
…iple-meshes Add option to merge mesh outputs into shared files
…ge-meshes Add mesh export threshold option
|
Hi @JuhaHuiskonen , Thanks a lot for the PR! I think it's a very valuable feature to be able to process all connected components within the segmentation. I'm a bit hesitant with this as it would break a bit the compatibility with subsequent steps (annotation in surforama, analysis in membrain-stats), so I would prefer to keep the 1 membrane <--> 1 .h5 container relation. What do you think? |
|
Hi, The meshes are written in the same container only if "--merge-outputs" option is given. The default is to write a separate file as you describe. Cheers, |
|
Ooh yes, I see it now. Thx for the clarification. Will try to review in detail as soon as possible! |
|
Hey @JuhaHuiskonen thanks for the PR! I had a look, and I’d prefer not to merge it for now. It’s quite a substantial change affecting many files, and I don’t currently have the right dataset or workflow to properly test all functionalities — especially the multiple membranes within a single .h5 container. Would it make sense to simplify things for now by keeping one .h5 container per membrane and leaving multi-membrane support for a later update? |
|
Of course. It seems to work for me as intended so we can proceed with our project. I am also happy to provide you some test data with multiple membranes in each tomogram. |
This is to implement features discussed in #43